Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Don't read primaryChild.childExpirationTime #18457

Merged
merged 1 commit into from Apr 1, 2020
Merged

Fix: Don't read primaryChild.childExpirationTime #18457

merged 1 commit into from Apr 1, 2020

Commits on Apr 1, 2020

  1. Fix: Don't read primaryChild.childExpirationTime 

    This is a variant of the fix in 5a0f1d. We can't rely on the primary
fiber's `childExpirationTime` field to be correct.

In this case, we can read from the Suspense boundary fiber instead.
This will include updates that exist in the fallback fiber, but that's
not a big deal; the important thing is that we don't drop updates.
    @acdlite
    acdlite committed Apr 1, 2020
    Copy the full SHA
    da358fc View commit details
    Browse the repository at this point in the history