Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear finished discrete updates during commit phase #18515

Merged
merged 4 commits into from Apr 7, 2020
Merged

Clear finished discrete updates during commit phase #18515

merged 4 commits into from Apr 7, 2020

Commits on Apr 7, 2020

  1. Reproduce a bug where flushDiscreteUpdates causes fallback never to… 

    … be committed
    @jddxf @acdlite
    jddxf authored and acdlite committed Apr 7, 2020
    Copy the full SHA
    5e28031 View commit details
    Browse the repository at this point in the history

  2. Ping suspended level when canceling its timer 

    Make sure the suspended level is marked as pinged so that we return back
to it later, in case the render we're about to start gets aborted.
Generally we only reach this path via a ping, but we shouldn't assume
that will always be the case.
    @acdlite
    acdlite committed Apr 7, 2020
    Copy the full SHA
    86adec4 View commit details
    Browse the repository at this point in the history

  3. Clear finished discrete updates during commit phase 

    If a root is finished at a priority lower than that of the latest pending discrete
updates on it, these updates must have been finished so we can clear them now.
Otherwise, a later call of `flushDiscreteUpdates` would start a new empty render
pass which may cause a scheduled timeout to be cancelled.
    @jddxf @acdlite
    jddxf authored and acdlite committed Apr 7, 2020
    Copy the full SHA
    60321ba View commit details
    Browse the repository at this point in the history

  4. Add TODO 

    Happened to find this while writing a test. A JSX element comparison
failed because one of them elements had a functional component as an
owner, which should ever happen.

I'll add a regression test later.
    @acdlite
    acdlite committed Apr 7, 2020
    Copy the full SHA
    6f67d0a View commit details
    Browse the repository at this point in the history