Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust fix for #18515 #18535

Merged
merged 2 commits into from Apr 8, 2020
Merged

More robust fix for #18515 #18535

merged 2 commits into from Apr 8, 2020

Commits on Apr 7, 2020

  1. Add another test for facebook#18515 using pings 

    Adds a regression test for the same underlying bug as facebook#18515 but using
pings.

Test already passes, but I confirmed it fails if you revert the fix
in facebook#18515.
    @acdlite
    acdlite committed Apr 7, 2020
    Copy the full SHA
    3ff151d View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Set nextPendingLevel after commit, too

    @acdlite
    acdlite committed Apr 8, 2020
    Copy the full SHA
    942d555 View commit details
    Browse the repository at this point in the history