Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help debugging: https://github.com/facebook/react/pull/18542 #18543

Closed
wants to merge 2 commits into from

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 8, 2020

We don't want to land this, this is purely to help test #18542.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 8, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 418364d:

Sandbox Source
delicate-firefly-x3vl0 Configuration

@sizebot
Copy link

sizebot commented Apr 8, 2020

Details of bundled changes.

Comparing: b225d4f...418364d

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.2% 270.91 KB 271.23 KB 46.57 KB 46.65 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.1% +0.2% 282.28 KB 282.6 KB 48.74 KB 48.82 KB RN_OSS_PROFILING
ReactFabric-prod.js 🔺+0.1% 🔺+0.2% 262.89 KB 263.21 KB 45.05 KB 45.13 KB RN_OSS_PROD
ReactFabric-profiling.js +0.1% +0.2% 274.27 KB 274.59 KB 47.22 KB 47.31 KB RN_OSS_PROFILING
ReactFabric-dev.js 0.0% +0.1% 637.88 KB 638.12 KB 136.21 KB 136.3 KB RN_FB_DEV
ReactFabric-prod.js 🔺+0.1% 🔺+0.2% 263.04 KB 263.36 KB 45.09 KB 45.17 KB RN_FB_PROD
ReactNativeRenderer-dev.js 0.0% +0.1% 653.75 KB 654 KB 140.33 KB 140.41 KB RN_OSS_DEV
ReactFabric-profiling.js +0.1% +0.2% 274.42 KB 274.74 KB 47.25 KB 47.34 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js 0.0% +0.1% 656.16 KB 656.4 KB 140.65 KB 140.74 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.2% 271.05 KB 271.37 KB 46.6 KB 46.68 KB RN_FB_PROD
ReactNativeRenderer-profiling.js +0.1% +0.2% 282.42 KB 282.74 KB 48.77 KB 48.85 KB RN_FB_PROFILING
ReactFabric-dev.js 0.0% +0.1% 635.46 KB 635.71 KB 135.9 KB 135.99 KB RN_OSS_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js +0.1% +0.1% 575.72 KB 576.12 KB 121.41 KB 121.52 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 38.72 KB 38.72 KB 9.42 KB 9.42 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 12.74 KB 12.74 KB 3.97 KB 3.98 KB UMD_PROD
react-test-renderer.development.js 0.0% +0.1% 568.39 KB 568.65 KB 118.2 KB 118.29 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.2% 74.17 KB 74.25 KB 22.56 KB 22.6 KB UMD_PROD
react-test-renderer.development.js 0.0% +0.1% 541.96 KB 542.2 KB 116.86 KB 116.95 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.2% 74 KB 74.08 KB 22.25 KB 22.29 KB NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js +0.1% +0.1% 127.81 KB 127.89 KB 39.89 KB 39.93 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 4.91 KB 4.91 KB 1.64 KB 1.64 KB UMD_DEV
ReactDOM-dev.js 0.0% +0.1% 977.37 KB 977.77 KB 216.7 KB 216.81 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 706 B 705 B UMD_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 408.56 KB 408.9 KB 73.9 KB 73.97 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 419.38 KB 419.71 KB 75.75 KB 75.82 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% 0.0% 75.14 KB 75.14 KB 20.11 KB 20.11 KB UMD_DEV
ReactDOMTesting-dev.js 0.0% 0.0% 929.91 KB 930.3 KB 207.15 KB 207.25 KB FB_WWW_DEV
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 393.2 KB 393.54 KB 71.65 KB 71.73 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 69.98 KB 69.98 KB 19.61 KB 19.61 KB NODE_DEV
ReactDOMTesting-profiling.js +0.1% +0.1% 393.2 KB 393.54 KB 71.65 KB 71.73 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 13.1 KB 13.1 KB 4.81 KB 4.81 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 23.69 KB 23.69 KB 8.72 KB 8.72 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 933.35 KB 933.62 KB 203.65 KB 203.74 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 56.11 KB 56.11 KB 13.85 KB 13.85 KB UMD_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 123.63 KB 123.72 KB 39.42 KB 39.47 KB UMD_PROD
ReactDOMForked-dev.js 0.0% +0.1% 977.37 KB 977.77 KB 216.7 KB 216.81 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10 KB 10 KB 3.36 KB 3.36 KB UMD_PROD
react-dom.profiling.min.js +0.1% +0.2% 127.47 KB 127.54 KB 40.63 KB 40.71 KB UMD_PROFILING
ReactDOMForked-prod.js 🔺+0.1% 🔺+0.1% 408.56 KB 408.9 KB 73.9 KB 73.97 KB FB_WWW_PROD
react-dom.development.js 0.0% 0.0% 888.75 KB 889 KB 201.17 KB 201.26 KB NODE_DEV
ReactDOMForked-profiling.js +0.1% +0.1% 419.38 KB 419.71 KB 75.75 KB 75.82 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 53.21 KB 53.21 KB 13.65 KB 13.65 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 5.18 KB 5.18 KB 1.7 KB 1.7 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 123.83 KB 123.92 KB 38.62 KB 38.67 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.75 KB 9.75 KB 3.26 KB 3.25 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js 0.0% +0.1% 650.67 KB 650.93 KB 136.59 KB 136.67 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 109.74 KB 109.82 KB 33.13 KB 33.17 KB UMD_PROD
react-art.development.js 0.0% +0.1% 554.4 KB 554.64 KB 119.07 KB 119.16 KB NODE_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.3% 74.71 KB 74.79 KB 22.33 KB 22.39 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 586.45 KB 586.84 KB 123.06 KB 123.17 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.1% 🔺+0.2% 240.77 KB 241.1 KB 40.65 KB 40.72 KB FB_WWW_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 418364d

@sizebot
Copy link

sizebot commented Apr 8, 2020

Details of bundled changes.

Comparing: b225d4f...418364d

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 119.69 KB 119.77 KB 37.52 KB 37.56 KB NODE_PROD
ReactDOMTesting-profiling.js +0.1% +0.1% 405.02 KB 405.36 KB 73.45 KB 73.52 KB FB_WWW_PROFILING
react-dom.profiling.min.js +0.1% +0.1% 123.54 KB 123.63 KB 38.66 KB 38.71 KB NODE_PROFILING
react-dom-server.node.production.min.js 0.0% -0.0% 23.23 KB 23.23 KB 8.65 KB 8.65 KB NODE_PROD
ReactDOMForked-dev.js 0.0% +0.1% 1005.25 KB 1005.65 KB 222.69 KB 222.81 KB FB_WWW_DEV
ReactDOMForked-prod.js 🔺+0.1% 🔺+0.1% 421.47 KB 421.81 KB 75.8 KB 75.88 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 5.16 KB 5.16 KB 1.69 KB 1.69 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 903.52 KB 903.79 KB 198.37 KB 198.46 KB UMD_DEV
ReactDOMForked-profiling.js +0.1% +0.1% 432.35 KB 432.68 KB 77.69 KB 77.76 KB FB_WWW_PROFILING
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 119.55 KB 119.64 KB 38.25 KB 38.29 KB UMD_PROD
react-dom.profiling.min.js +0.1% +0.2% 123.27 KB 123.36 KB 39.48 KB 39.54 KB UMD_PROFILING
ReactDOMTesting-dev.js 0.0% 0.0% 956.46 KB 956.85 KB 212.77 KB 212.87 KB FB_WWW_DEV
react-dom.development.js 0.0% 0.0% 860.16 KB 860.4 KB 195.9 KB 195.98 KB NODE_DEV
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 405.02 KB 405.36 KB 73.45 KB 73.52 KB FB_WWW_PROD
ReactDOM-dev.js 0.0% +0.1% 1005.25 KB 1005.65 KB 222.69 KB 222.81 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 421.47 KB 421.81 KB 75.8 KB 75.88 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 4.42 KB 4.42 KB 1.54 KB 1.54 KB NODE_DEV
ReactDOM-profiling.js +0.1% +0.1% 432.35 KB 432.68 KB 77.69 KB 77.76 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 13.09 KB 13.09 KB 4.8 KB 4.8 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 56.1 KB 56.1 KB 13.84 KB 13.84 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 9.98 KB 9.98 KB 3.36 KB 3.36 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 53.2 KB 53.2 KB 13.64 KB 13.64 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 9.73 KB 9.73 KB 3.25 KB 3.25 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js 0.0% +0.1% 653.74 KB 653.99 KB 140.32 KB 140.41 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.2% 270.89 KB 271.21 KB 46.56 KB 46.64 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.1% +0.2% 282.27 KB 282.59 KB 48.73 KB 48.81 KB RN_OSS_PROFILING
ReactFabric-dev.js 0.0% +0.1% 635.45 KB 635.7 KB 135.9 KB 135.99 KB RN_OSS_DEV
ReactFabric-prod.js 🔺+0.1% 🔺+0.2% 262.88 KB 263.2 KB 45.04 KB 45.12 KB RN_OSS_PROD
ReactFabric-profiling.js +0.1% +0.2% 274.25 KB 274.57 KB 47.22 KB 47.3 KB RN_OSS_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js 0.0% +0.1% 630.4 KB 630.66 KB 132.89 KB 132.98 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 107.13 KB 107.21 KB 32.46 KB 32.5 KB UMD_PROD
react-art.development.js 0.0% +0.1% 534.92 KB 535.17 KB 115.3 KB 115.39 KB NODE_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.2% 72.15 KB 72.23 KB 21.66 KB 21.72 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 596.51 KB 596.91 KB 125.04 KB 125.16 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.1% 🔺+0.2% 248.21 KB 248.55 KB 41.94 KB 42 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% +0.1% 568.36 KB 568.63 KB 118.18 KB 118.28 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.2% 74.15 KB 74.23 KB 22.54 KB 22.58 KB UMD_PROD
react-test-renderer-shallow.production.min.js 0.0% 0.0% 12.73 KB 12.73 KB 3.97 KB 3.97 KB UMD_PROD
react-test-renderer.development.js 0.0% +0.1% 541.93 KB 542.18 KB 116.84 KB 116.93 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.2% 73.97 KB 74.06 KB 22.23 KB 22.28 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 575.71 KB 576.11 KB 121.4 KB 121.51 KB FB_WWW_DEV

Size changes (stable)

Generated by 🚫 dangerJS against 418364d

@trueadm trueadm closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants