Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable console.logs in the second render pass of DEV mode double render #18547

Merged
merged 3 commits into from Apr 8, 2020
Merged

Disable console.logs in the second render pass of DEV mode double render #18547

merged 3 commits into from Apr 8, 2020

Commits on Apr 8, 2020

  1. Disable console log during the second rerender

    @sebmarkbage
    sebmarkbage committed Apr 8, 2020
    Copy the full SHA
    057e4a0 View commit details
    Browse the repository at this point in the history

  2. Use the disabled log to avoid double yielding values in scheduler mock

    @sebmarkbage
    sebmarkbage committed Apr 8, 2020
    Copy the full SHA
    2d742e5 View commit details
    Browse the repository at this point in the history

  3. Reenable debugRenderPhaseSideEffectsForStrictMode in tests that can

    @sebmarkbage
    sebmarkbage committed Apr 8, 2020
    Copy the full SHA
    b7e2345 View commit details
    Browse the repository at this point in the history