Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Component Stacks from Native Stack Frames #18561

Merged
merged 9 commits into from Apr 10, 2020
Merged

Build Component Stacks from Native Stack Frames #18561

merged 9 commits into from Apr 10, 2020

Commits on Apr 10, 2020

  1. Implement component stack extraction hack

    @sebmarkbage
    sebmarkbage committed Apr 10, 2020
    Copy the full SHA
    d0710d0 View commit details
    Browse the repository at this point in the history

  2. Cache the result in DEV 

    In DEV it's somewhat likely that we'll see many logs that add component
stacks. This could be slow so we cache the results of previous components.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2020
    Copy the full SHA
    91b5f34 View commit details
    Browse the repository at this point in the history

  3. Fix special case when the function call throws in V8 

    In V8 we need to ignore the first line. Normally we would never get there
because the stacks would differ before that, but the stacks are the same if
we end up throwing at the same place as the control.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2020
    Copy the full SHA
    ffc3006 View commit details
    Browse the repository at this point in the history

  4. Log if out of range.

    @sebmarkbage
    sebmarkbage committed Apr 10, 2020
    Copy the full SHA
    0f2f008 View commit details
    Browse the repository at this point in the history

  5. Normalize errors in tests 

    This drops the requirement to include owner to pass the test.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2020
    Copy the full SHA
    0575e9f View commit details
    Browse the repository at this point in the history

  6. Special case tests

    @sebmarkbage
    sebmarkbage committed Apr 10, 2020
    Copy the full SHA
    0b317f2 View commit details
    Browse the repository at this point in the history

  7. Add destructuring to force toObject which throws before the side-effects 

    This ensures that we don't double call yieldValue or advanceTime in tests.

Ideally we could use empty destructuring but ES lint doesn't like it.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2020
    Copy the full SHA
    66e67d5 View commit details
    Browse the repository at this point in the history

  8. Add Reflect to lint

    @sebmarkbage
    sebmarkbage committed Apr 10, 2020
    Copy the full SHA
    df0ef46 View commit details
    Browse the repository at this point in the history

  9. Fixture

    @sebmarkbage
    sebmarkbage committed Apr 10, 2020
    Copy the full SHA
    fbb0189 View commit details
    Browse the repository at this point in the history