Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Component Stacks for IE and Native Classes in Safari #18575

Merged
merged 5 commits into from Apr 11, 2020
Merged

Fix Component Stacks for IE and Native Classes in Safari #18575

merged 5 commits into from Apr 11, 2020

Commits on Apr 11, 2020

  1. Add more edge cases to fixture 

    Also adjust some expectations. I think the column should ideally be 1 but varies.
The Example row is one line off because it throws on the hook but should ideally be the component.
Similarly class components with constructors may have the line in the constructor.
    @sebmarkbage
    sebmarkbage committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    ac9651d View commit details
    Browse the repository at this point in the history

  2. Account for the construct call taking a stack frame 

    We do this by first searching for the first different frame, then find
the same frames and then find the first different frame again.
    @sebmarkbage
    sebmarkbage committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    526ce6e View commit details
    Browse the repository at this point in the history

  3. Throw controls 

    Otherwise they don't get a stack frame associated with them in IE.
    @sebmarkbage
    sebmarkbage committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    29bc28a View commit details
    Browse the repository at this point in the history

  4. Protect against generating stacks failing 

    Errors while generating stacks will bubble to the root. Since this technique
is a bit sketchy, we should probably protect against it.
    @sebmarkbage
    sebmarkbage committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    8a7097f View commit details
    Browse the repository at this point in the history

  5. Don't construct the thing that throws 

    Instead, we pass the prototype as the "this". It's new every time anyway.
    @sebmarkbage
    sebmarkbage committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    5007c88 View commit details
    Browse the repository at this point in the history