Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools: Improved "native" component stacks #18656

Merged
merged 8 commits into from
Apr 21, 2020
Merged

DevTools: Improved "native" component stacks #18656

merged 8 commits into from
Apr 21, 2020

Commits on Apr 21, 2020

  1. DevTools console override handles new component stack format 

    DevTools does not attempt to mimic the default browser console format for its component stacks but it does properly detect the new format for Chrome, Firefox, and Safari.
    Brian Vaughn committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    47ebddc View commit details
    Browse the repository at this point in the history

  2. Inject getStackByFiberInDevAndProd() to DevTools 

    dquote>
dquote> This enables "native" component stacks (clickable) for third party warnings as well.
    Brian Vaughn committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    2b62646 View commit details
    Browse the repository at this point in the history

  3. DevTools imports getStackByFiberInDevAndProd() directly 

    Added DevTools fork of ReactFeatureFlags to make this possible.
    Brian Vaughn committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    c6f7852 View commit details
    Browse the repository at this point in the history

  4. Backed out DevTools feature flag fork in favor of global env vars

    Brian Vaughn committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    a775fa4 View commit details
    Browse the repository at this point in the history

  5. Forked ComponentStackFrame and FiberComponentStack into DevTools

    Brian Vaughn committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    cba7e94 View commit details
    Browse the repository at this point in the history

  6. Typo fix

    Brian Vaughn committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    6e98033 View commit details
    Browse the repository at this point in the history

  7. Replaced regex .exec() with .test()

    Brian Vaughn committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    6474d2f View commit details
    Browse the repository at this point in the history

  8. Made fallback regex more multiline friendly

    Brian Vaughn committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    2033ced View commit details
    Browse the repository at this point in the history