Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #18657 #18663

Merged
merged 2 commits into from Apr 17, 2020
Merged

Fix for #18657 #18663

merged 2 commits into from Apr 17, 2020

Commits on Apr 17, 2020

  1. Failing test for facebook#18657

    @acdlite
    acdlite committed Apr 17, 2020
    Copy the full SHA
    b7a0583 View commit details
    Browse the repository at this point in the history

  2. Remove incorrect priority check 

    I think this was just poor factoring on my part in facebook#18411. Honestly it
doesn't make much sense to me, but my best guess is that I must have
thought that when `baseTime > currentChildExpirationTime`, the function
would fall through to the
`currentChildExpirationTime < renderExpirationTime` branch below.

Really I think just made an oopsie.

Regardless, this logic is galaxy brainéd. A goal of the Lanes refactor
I'm working on is to make these types of checks -- is there remaining
work in this tree? -- a lot easier to think about. Hopefully.
    @acdlite
    acdlite committed Apr 17, 2020
    Copy the full SHA
    c673395 View commit details
    Browse the repository at this point in the history