Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root API should clear non-empty roots before mounting #18730

Merged
merged 6 commits into from Apr 28, 2020
Merged

Root API should clear non-empty roots before mounting #18730

merged 6 commits into from Apr 28, 2020

Commits on Apr 27, 2020

  1. Root API should clear non-empty roots before mounting 

    Legacy render-into-subtree API removes children from a container before rendering into it. The root API did not do this previously, but just left the children around in the document.

This commit adds a new FiberRoot flag to clear a container's contents before mounting. This is done during the commit phase, to avoid multiple, observable mutations.
    Brian Vaughn committed Apr 27, 2020
    Copy the full SHA
    c5a1768 View commit details
    Browse the repository at this point in the history

  2. Replaced new root attribute with ClearContainer effect

    Brian Vaughn committed Apr 27, 2020
    Copy the full SHA
    95bdde0 View commit details
    Browse the repository at this point in the history

  3. Replaced ClearContainer tag with Snapshot for clearing HostRoots

    Brian Vaughn committed Apr 27, 2020
    Copy the full SHA
    317fb78 View commit details
    Browse the repository at this point in the history

  4. Check root.hydrate before scheduling root to be cleared 

    This avoids breaking support for ReactDOM.hydration in legacy mode with no fallback.
    Brian Vaughn committed Apr 27, 2020
    Copy the full SHA
    f318360 View commit details
    Browse the repository at this point in the history

  5. Custom config fix

    Brian Vaughn committed Apr 27, 2020
    Copy the full SHA
    39b2042 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Clear body instead of document; use textContent instead of innerHTML

    Brian Vaughn committed Apr 28, 2020
    Copy the full SHA
    f45a8a1 View commit details
    Browse the repository at this point in the history