Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rollup validate script #18900

Merged
merged 2 commits into from May 27, 2020

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented May 12, 2020

Summary

This reverts #18899 and re-enables #18897.
The issue is caused by eslint/eslint#12888 because ESLint v7 ignores node_modules/* in subdirectories.
To fix this, I've add !/build/node_modules/* into eslintignore for the rollup validate script.
I've tested this with yarn lint-build. Is there anything else I have to test?
Should I add a check to run yarn lint-build at every PRs?

Test Plan

yarn lint-build

➜  yarn lint-build
yarn run v1.22.4
$ node ./scripts/rollup/validate/index.js
Checking if files exist in ./build/react-native/implementations/*.js...
Found 12 bundles.

Checking if files exist in ./build/node_modules/*/umd/*.js...
Found 32 bundles.

Checking if files exist in ./build/node_modules/*/*.js...
Found 54 bundles.

Checking if files exist in ./build/node_modules/*/cjs/*.js...
Found 90 bundles.

Linting rn bundles...
Linted rn bundles successfully!

Linting umd bundles...
Linted umd bundles successfully!

Linting cjs bundles...
Linted cjs bundles successfully!

✨  Done in 12.83s.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9a586cc:

Sandbox Source
jolly-zhukovsky-zim1u Configuration

@koba04 koba04 force-pushed the fix-ignore-build-files-with-lint branch from 28a0072 to 9a586cc Compare May 15, 2020 04:51
@gaearon gaearon merged commit fb73542 into facebook:master May 27, 2020
@koba04 koba04 deleted the fix-ignore-build-files-with-lint branch May 27, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants