Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix state leaking when a function component throws on server render #19212

Merged
merged 6 commits into from Jul 8, 2020
Merged

Fix state leaking when a function component throws on server render #19212

merged 6 commits into from Jul 8, 2020

Commits on Jul 7, 2020

  1. add unit test asserting internal hooks state is reset

    @pmaccart
    pmaccart committed Jul 7, 2020
    Copy the full SHA
    64f35a1 View commit details
    Browse the repository at this point in the history

  2. Reset internal hooks state before rendering

    @pmaccart
    pmaccart committed Jul 7, 2020
    Copy the full SHA
    d348ec2 View commit details
    Browse the repository at this point in the history

  3. reset hooks state on error

    @pmaccart
    pmaccart committed Jul 7, 2020
    Copy the full SHA
    398116c View commit details
    Browse the repository at this point in the history

  4. Use expect...toThrow instead of try/catch in test

    @pmaccart
    pmaccart committed Jul 7, 2020
    Copy the full SHA
    e8dfb29 View commit details
    Browse the repository at this point in the history

  5. reset dev-only hooks state inside resetHooksState

    @pmaccart
    pmaccart committed Jul 7, 2020
    Copy the full SHA
    cb3b104 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. reset currentlyRenderingComponent to null

    @pmaccart
    pmaccart committed Jul 8, 2020
    Copy the full SHA
    21fdac0 View commit details
    Browse the repository at this point in the history