Fix development mode hang when iframe is removed #19220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
This was referenced Jun 30, 2020
Closed
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit af57488:
|
Details of bundled changes.Comparing: 47ff31a...af57488 react-dom
react-art
react-test-renderer
react-native-renderer
react-reconciler
Size changes (stable) |
Details of bundled changes.Comparing: 47ff31a...af57488 react-dom
react-native-renderer
react-art
react-test-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
sophiebits
approved these changes
Jun 30, 2020
| @@ -138,7 +133,15 @@ if (__DEV__) { | |||
| ) { | |||
| window.event = windowEvent; | |||
There was a problem hiding this comment.
I wonder why this doesn't do
if (windowEventDescriptor) {
Object.defineProperty(window, 'event', windowEventDescriptor);
}as below.
There was a problem hiding this comment.
I'm scared to touch it. #11696 (comment)
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified it fixes #16585.
Verified it fixes #16734.
Follows @sophiebits's suggestion in #16734 (comment).
This is a workaround for a Chrome bug that also exists in Safari and doesn't seem to be gaining momentum. The actual cases in which this happens may be niche but I have a hunch I've run into other manifestations of this issue so I think it's worth fixing.
The basic idea is that if our shim doesn't work, we fall back to prod behavior with a simple try/catch.