Modern Event System: make on*Capture events use capture phase #19221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d8e5480:
|
Details of bundled changes.Comparing: 4eb9b1d...d8e5480 react-dom
ReactDOM: size: 0.0%, gzip: 🔺+0.1% Size changes (stable) |
Details of bundled changes.Comparing: 4eb9b1d...d8e5480 react-dom
ReactDOM: size: 0.0%, gzip: 🔺+0.1% Size changes (experimental) |
trueadm
force-pushed
the
use-capture-phase-b
branch
7 times, most recently
from
15ac292
to
c1fac38
Compare
trueadm
force-pushed
the
use-capture-phase-b
branch
2 times, most recently
from
ef10361
to
52b692b
Compare
trueadm
force-pushed
the
use-capture-phase-b
branch
2 times, most recently
from
9768ac4
to
814b227
Compare
gaearon
reviewed
Jul 6, 2020
|
@gaearon What Map access were you referencing specifically? I was also of the understanding that the difference was tiny, especially when the inline cache is utilized. I remember this being a perf issue a few years back with V8, but Sets and Maps are really fast now. |
trueadm
force-pushed
the
use-capture-phase-b
branch
5 times, most recently
from
6dbd8ce
to
f888b6c
Compare
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is rebased on #19244.
This PR alters the modern event system so that events that are of the format
on*Capture(capture events) are actually put into the browser's native capture event phase when React creates the event listener. This is a deparature of the previous logic, which "virtualized" the capture and bubble phases within the native bubble event listener.This is an important change to the modern event system, as the modern event system delegates to React roots (or portals) rather than the
document. This means events that are setup to be capture listener, i.e.onClickCapturenow correctly behave has expected. This also fixes some long-standing issues with how React and the browser differ in regards to how events are handled in co-ordination with native event listeners.Lastly, we still (for now) enforce
blurandfocusto be capture phase listeners (so they emulate two phase propagation in the native capture phase, as we did before). We also emulate two phase propagation in the native bubble phase, as we did before, for theChangeEventPlugin,BeforeInputEventPluginandSelectEventPluginevent plugins.