Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user timing marks for scheduling profiler tool #19223

Merged
merged 39 commits into from
Jul 8, 2020
Merged

Add user timing marks for scheduling profiler tool #19223

merged 39 commits into from
Jul 8, 2020

Commits on Jun 18, 2020

  1. Add enableSchedulingProfiler feature flag

    @taneliang
    taneliang committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    ec17600 View commit details
    Browse the repository at this point in the history

  2. Add mark utility functions 

    Combines those defined in both DebugTracing.js and
[this branch](facebook/react@master...bvaughn:root-event-marks#diff-9c522844edfceec1e53144f429f7103fR123).
    @taneliang
    taneliang committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    3e5f821 View commit details
    Browse the repository at this point in the history

  3. Rename enableSchedulingProfiler -> enableSchedulingProfiling

    @taneliang
    taneliang committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    ed384aa View commit details
    Browse the repository at this point in the history

  4. Add all marks except commits and effects

    @taneliang
    taneliang committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    c5c6bd4 View commit details
    Browse the repository at this point in the history

  5. Reduce performance API requirements

    @taneliang
    taneliang committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    054781d View commit details
    Browse the repository at this point in the history

  6. Add tests for SchedulingProfiling

    @taneliang
    taneliang committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    5fb8525 View commit details
    Browse the repository at this point in the history

  7. Comment out tests covering Kartik's code

    @taneliang
    taneliang committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    eec07b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Add tests to cover markRenderAbandoned and fix passive effect marks

    @taneliang
    taneliang committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    560c396 View commit details
    Browse the repository at this point in the history

  2. Comment out tests covering Kartik's code

    @taneliang
    taneliang committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    414866d View commit details
    Browse the repository at this point in the history

  3. Add remaining user timing marks

    @kartikcho
    kartikcho committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    791dae7 View commit details
    Browse the repository at this point in the history

  4. Re add tests

    @kartikcho
    kartikcho committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    63580cd View commit details
    Browse the repository at this point in the history

  5. Add missing markCommitStopped calls, relocated some mark* calls for c… 

    …onsistency, add blank lines
    @taneliang
    taneliang committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    30d5f7e View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Replace binary lane bitmask with decimal for compactness

    @taneliang
    taneliang committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    68d6430 View commit details
    Browse the repository at this point in the history

  2. Reduce test strictness to fix test-prod

    @taneliang
    taneliang committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    7ce6931 View commit details
    Browse the repository at this point in the history

  3. Remove TODO for markRenderScheduled

    @taneliang
    taneliang committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    418d02a View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Merge branch 'master' into eliang/scheduling-profiler-marks

    @taneliang
    taneliang committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    4f6846a View commit details
    Browse the repository at this point in the history

  2. Add markCommitStarted call to new logCommitStarted location

    @taneliang
    taneliang committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    d3d0459 View commit details
    Browse the repository at this point in the history

  3. Remove markRenderAbandoned

    @taneliang
    taneliang committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    4101fd7 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Merge branch 'master' into eliang/scheduling-profiler-marks

    @taneliang
    taneliang committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    9f64b78 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Merge branch 'master' into eliang/scheduling-profiler-marks

    @taneliang
    taneliang committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    36e79f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Rename enableSchedulingProfiling -> enableSchedulingProfiler 

    Resolves PR comment facebook#19223 (comment)
    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    1628476 View commit details
    Browse the repository at this point in the history

  2. Remove component name from markRenderScheduled 

    Resolves PR review comment facebook#19223 (comment)
    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    660559d View commit details
    Browse the repository at this point in the history

  3. Remove componentName arguments 

    Resolves PR review comment facebook#19223 (comment)
    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    501c4b9 View commit details
    Browse the repository at this point in the history

  4. Reorder schedule update info 

    Resolves PR review comment facebook#19223 (comment)
    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    b716ad0 View commit details
    Browse the repository at this point in the history

  5. Remove component stack from schedule render marks 

    Resolves PR review comment facebook#19223 (comment)
    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    06b038d View commit details
    Browse the repository at this point in the history

  6. Add missing Wakeable import

    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    c014d6e View commit details
    Browse the repository at this point in the history

  7. Implement component stack cache 

    Resolves PR review comments:
1. facebook#19223 (comment)
1. facebook#19223 (comment)
    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    8fd53ea View commit details
    Browse the repository at this point in the history

  8. Add __PROFILE__ to enableDebugTracing

    @kartikcho
    kartikcho committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    142d5c1 View commit details
    Browse the repository at this point in the history

  9. Destructure enableDebugTracing and enableSchedulingProfiling to dynam… 

    …icFeatureFlags
    @kartikcho
    kartikcho committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    3c477c4 View commit details
    Browse the repository at this point in the history

  10. Rename SchedulingProfiling -> SchedulingProfiler

    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    1b12ee5 View commit details
    Browse the repository at this point in the history

  11. Add __PROFILE__ to enableSchedulingProfiler instead 

    Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>
    @taneliang @bvaughn
    taneliang and bvaughn committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    f42b0a0 View commit details
    Browse the repository at this point in the history

  12. Use cached fiber.alternate component stacks if present

    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    6a23d18 View commit details
    Browse the repository at this point in the history

  13. Remove stray redundant empty string fallbacks

    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    1c5997e View commit details
    Browse the repository at this point in the history

  14. Reorder --suspense-* mark info 

    Resolves PR review comment facebook#19223 (comment)
    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    8e529f4 View commit details
    Browse the repository at this point in the history

  15. Use single quotes for --commit-stop

    @taneliang
    taneliang committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    4b51d6d View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Move TODO back to getStackByFiberInDevAndProd callsite

    @taneliang
    taneliang committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    c104dc0 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Remove unused fiber markRenderScheduled param

    @taneliang
    taneliang committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    ca75690 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into eliang/scheduling-profiler-marks

    @taneliang
    taneliang committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d2c090e View commit details
    Browse the repository at this point in the history

  3. Remove @GATE experimental condition

    @taneliang
    taneliang committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b766b17 View commit details
    Browse the repository at this point in the history