fix: onFocus/onBlur/onBeforeInput have a matching event type #19561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 30c564b:
|
Details of bundled changes.Comparing: 0cd9a6d...30c564b react-dom
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Size changes (experimental) |
eps1lon
commented
Aug 8, 2020
| @@ -36,7 +36,7 @@ function initializeModules(hasPointerEvents) { | |||
| const forcePointerEvents = true; | |||
| const table = [[forcePointerEvents], [!forcePointerEvents]]; | |||
|
|
|||
| describe.each(table)(`useFocus`, hasPointerEvents => { | |||
| describe.each(table)(`useFocus hasPointerEvents=%s`, hasPointerEvents => { | |||
There was a problem hiding this comment.
was slightly confusing why we had two tests with the same name.
Details of bundled changes.Comparing: 0cd9a6d...30c564b react-dom
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Size changes (stable) |
eps1lon
commented
Aug 8, 2020
...es/react-interactions/events/src/dom/create-event-handle/__tests__/useFocus-test.internal.js
Outdated
Show resolved
Hide resolved
eps1lon
force-pushed
the
fix/focus-event-type
branch
from
ff641a5
to
cc2ae0c
Compare
trueadm
reviewed
Aug 8, 2020
|
Hmm. I was hoping we could do this with a bit less code than creating two more functions etc. Any other ideas? |
In the end we had one component that relied on |
gaearon
force-pushed
the
fix/focus-event-type
branch
from
f98cb9b
to
30c564b
Compare
|
I pushed a different fix. We already have a switch so we can just reuse it to set the Added a regression suite. |
gaearon
changed the title
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So far
event.typealways matched the listener name in React even though the underlying native event might be a different type (e.g.onMouseEnter). The recent changes to focus events madeonFocusandonBlurthe only two events whoseevent.typedid not match (onFocus->focusin,onBlur->focusout).This PR restores the previous event types.
Closes #19560
Test Plan
It might make sense to write a regression test suite (similar to #19483) for all event types since it seems that
event.typeisn't tested. I could split this work up into two PRs (one for the test, one for the fix) in case you need to revert the fix.