Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach Listeners Eagerly to Roots and Portal Containers #19659

Merged
merged 4 commits into from Aug 24, 2020

Commits on Aug 21, 2020

  1. Failing test for facebook#19608

    koba04 authored and gaearon committed Aug 21, 2020
    Copy the full SHA
    c232f0c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    49216d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Forbid createEventHandle with custom events

    We can't support this without adding more complexity. It's not clear that this is even desirable, as none of our existing use cases need custom events. This API primarily exists as a deprecation strategy for Flare, so I don't think it is important to expand its support beyond what Flare replacement code currently needs. We can later revisit it with a better understanding of the eager/lazy tradeoff but for now let's remove the inconsistency.
    gaearon committed Aug 24, 2020
    Copy the full SHA
    9bf255b View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    46ee6be View commit details
    Browse the repository at this point in the history