Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test for Context.Consumer in suspended Suspense #19702

Closed
wants to merge 1 commit into from
Closed

Failing test for Context.Consumer in suspended Suspense #19702

wants to merge 1 commit into from

Conversation

overlookmotel
Copy link
Contributor

Failing test for issue #19701.

Apologies if I'm not understanding the correct use of expect(Scheduler).toHaveYielded().

@overlookmotel overlookmotel mentioned this pull request Aug 26, 2020
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 26, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2448504:

Sandbox Source
React Configuration

@overlookmotel overlookmotel force-pushed the suspense-context-consumer-failing-test branch from bb051ea to 2448504 Compare August 26, 2020 19:20
@sizebot
Copy link

sizebot commented Aug 26, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 2448504

@sizebot
Copy link

sizebot commented Aug 26, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 2448504

@engprodigy
Copy link

@overlookmotel and @gaearon This is looking abandoned. Can I take a look at it?

@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Dec 25, 2020
@eps1lon
Copy link
Collaborator

eps1lon commented Dec 25, 2020

Bump

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Dec 25, 2020
@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 9, 2022
@overlookmotel
Copy link
Contributor Author

Still relevant I think!

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2022
@gaearon gaearon mentioned this pull request Jan 11, 2022
Merged
@gaearon
Copy link
Collaborator

gaearon commented Jan 11, 2022

Thanks. Potential fix in #23095.

@gaearon gaearon closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@overlookmotel @sizebot @engprodigy @eps1lon @gaearon @facebook-github-bot