Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context propagation for offscreen/fallback trees #23095

Merged
merged 7 commits into from Jan 19, 2022

Commits on Jan 11, 2022

  1. Configuration menu
    Copy the full SHA
    d6dc202 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ce097b View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Address nits

    gaearon committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    92c5c04 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7d93066 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Pass correct propagation root

    gaearon committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    09a1975 View commit details
    Browse the repository at this point in the history
  2. Harden test coverage

    This test will fail if we remove propagation, or if we propagate with a root node like fiber.return or fiber.return.return. The additional DEV-only error helps detect a different kind of mistake, like if the thing being passed hasn't actually been encountered on the way up. However, we still leave the actual production loop to check against null so that there is no way we loop forever if the propagation root is wrong.
    gaearon committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    1fed15d View commit details
    Browse the repository at this point in the history
  3. Remove superfluous warning

    gaearon committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    d465a97 View commit details
    Browse the repository at this point in the history