Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore checking client entry point for UMD build #24274

Merged
merged 1 commit into from Apr 5, 2022

Conversation

alireza-molaee
Copy link
Contributor

Summary

it solve (React DOM UMD always warns in React 18 #24221)
for UMD build it does not matter entry point, so we can ignore checking entry point.

How did you test this change?

build react-dom and check bundle file (react-dom.development.js)

@facebook-github-bot
Copy link

Hi @alireza-molaee!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Apr 4, 2022

Oh wait, we have this constant? I totally forgot!

@alireza-molaee
Copy link
Contributor Author

I submit CLA form. Do I have to do anything else to continue?

@gaearon
Copy link
Collaborator

gaearon commented Apr 4, 2022

No, let's give it a bit of time!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@sizebot
Copy link

sizebot commented Apr 5, 2022

Comparing: 9ededef...39e3a81

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.40 kB 131.40 kB = 41.98 kB 41.99 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.45 kB 136.45 kB = 43.43 kB 43.43 kB
facebook-www/ReactDOM-prod.classic.js = 433.07 kB 433.07 kB = 79.60 kB 79.60 kB
facebook-www/ReactDOM-prod.modern.js = 418.07 kB 418.07 kB = 77.24 kB 77.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 433.07 kB 433.07 kB = 79.60 kB 79.61 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 39e3a81

@gaearon gaearon merged commit 1d1fa94 into facebook:main Apr 5, 2022
@gaearon
Copy link
Collaborator

gaearon commented Apr 5, 2022

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants