Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hydration code out of normal Suspense path #24532

Merged
merged 2 commits into from May 25, 2022
Merged

Move hydration code out of normal Suspense path #24532

merged 2 commits into from May 25, 2022

Commits on May 25, 2022

  1. Move hydration code out of normal Suspense path 

    Shuffling some code around to make it easier to follow. The logic for
updating a dehydrated Suspense boundary is significantly different
from the logic for a client-rendered Suspense boundary. Most of it was
already lifted out into a separate function; this moves the remaining
hydration-specific logic out of updateSuspenseComponent and into
updateDehydratedSuspenseComponent instead.

No expected changes to program behavior.
    @acdlite
    acdlite committed May 25, 2022
    Copy the full SHA
    aeaf8bb View commit details
    Browse the repository at this point in the history

  2. Extract hydration logic in complete phase, too 

    Same as previous step but for the complete phase. This is a separate
commit to make bisecting easier in case something breaks. The logic
is very subtle but mostly all I've done is extract it to
another function.
    @acdlite
    acdlite committed May 25, 2022
    Copy the full SHA
    01562b7 View commit details
    Browse the repository at this point in the history