Flow: remove max_workers setting #25349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kassens
force-pushed
the
flow-workers
branch
from
b71606f
to
e4838d2
Compare
This was added back in facebook#17880 to make CI pass for an unrelated change. Submitting this PR to see if this is still needed to pass on CI. A lot of things have changed since.
kassens
force-pushed
the
flow-workers
branch
from
e4838d2
to
42e084e
Compare
rickhanlonii
pushed a commit
that referenced
this pull request
Oct 5, 2022
This was added back in #17880 to make CI pass for an unrelated change. This limits the max worker setting to CI environments as removing the setting completely still seems to break on CircleCI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added back in #17880 to make CI pass for an unrelated change.
This limits the max worker setting to CI environments as removing the setting completely still seems to break on CircleCI.