Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup enableFilterEmptyStringAttributesDOM flag #28744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleanup enableFilterEmptyStringAttributesDOM flag #28744

wants to merge 1 commit into from

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 4, 2024

Cleanup enableFilterEmptyStringAttributesDOM flag

It's true everywhere.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 4, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 4, 2024 •
edited

Comparing: 6090cab...d87a9f9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 169.41 kB 169.41 kB = 52.83 kB 52.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.22 kB 171.22 kB = 53.36 kB 53.37 kB
facebook-www/ReactDOM-prod.classic.js = 590.17 kB 590.17 kB = 103.70 kB 103.70 kB
facebook-www/ReactDOM-prod.modern.js = 566.53 kB 566.53 kB = 99.64 kB 99.64 kB
test_utils/ReactAllWarnings.js Deleted 64.21 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.21 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against d87a9f9

@kassens kassens requested review from rickhanlonii and sebmarkbage and removed request for rickhanlonii April 4, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kassens @react-sizebot @facebook-github-bot