Use undici polyfill for tests in old Node versions #28887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
CI should be running with 18.20 as of 50895bc |
|
This is still valuable to test in old Node versions manually. I guess the question is, which versions do we support? |
sebmarkbage
commented
Apr 23, 2024
| const blob = new Blob([typedArray]); | ||
| const blob = new Blob([ | ||
| // We should be able to pass the buffer straight through but Node < 18 treat | ||
| // multi-byte array blobs differently so we first convert it to single-byte. |
There was a problem hiding this comment.
These are only relevant in Server-to-Server calls and maybe SSR serialization of forms. The question is do we support old Node without polyfilling?
There was a problem hiding this comment.
IMO we should only support supported versions of Node so we can probably assume FormData
gnoff
approved these changes
Apr 25, 2024
To support old Node we need to adjust how we construct blobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't test FormData / File dependent features in CI because we use an old Node.js version in CI. We should probably upgrade to 18 since that's really the minimum version that supports all the features out of the box.
JSDOM is not a faithful/compatible implementation of these APIs. The recommended way to use Flight together with FormData/Blob/File in older Node.js versions, is to polyfill using the
undicilibrary.However, even in these versions the Blob implementation isn't quite faithful so the Reply client needs a slight tweak for multi-byte typed arrays.