Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hydrateRoot): to check and add validations for type check of arguments in hydrateRoot while development #28934

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shubhdeep12
Copy link

@Shubhdeep12 Shubhdeep12 commented Apr 27, 2024

Summary

fixes: #28792
Added a validation and type check for arguments of hydrateRoot

How did you test this change?

@Shubhdeep12 Shubhdeep12 changed the title fix(hydrate): to check and add validations for type check of argument… fix(hydrateRoot): to check and add validations for type check of arguments in hydrateRoot while development Apr 27, 2024
@react-sizebot
Copy link

Comparing: 4ddff73...1700b45

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
facebook-www/ReactDOM-prod.classic.js = 591.11 kB 591.11 kB = 103.94 kB 103.94 kB
facebook-www/ReactDOM-prod.modern.js = 567.33 kB 567.33 kB = 100.34 kB 100.34 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 1700b45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Invalid options to hydrateRoot can error with "This root received an early update"
3 participants