Build React DOM Fiber package #7173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
sebmarkbage
force-pushed
the
fiberbuild
branch
5 times, most recently
from
4375715
to
f28b2c9
Compare
sebmarkbage
force-pushed
the
fiberbuild
branch
from
f28b2c9
to
eb78669
Compare
|
Let's warn on require time for ReactDOMFiber so it's obvious that this is an unsupported API. |
This builds a `react-dom-fiber.js` bundle which exposes ReactDOMFiber. This allows early experiments with the new Fiber reconciler. I also expose it in the npm package through `react-dom/fiber`.
sebmarkbage
force-pushed
the
fiberbuild
branch
from
eb78669
to
4e36bf3
Compare
|
So… do we want to ship this publicly yet? It's definitely unsupported but people might get the wrong idea and think we're going to support this soon. |
|
If you try to use it, it prints a pretty aggressive warning. I think it's fine to ship CommonJS support but not publish (or be quiet about) UMDs. |
| warning( | ||
| warned, | ||
| 'You are using React DOM Fiber which is an experimental renderer. ' + | ||
| 'It is likely to have bugs, breaking changes and is unsupported.' |
There was a problem hiding this comment.
This is the warning that fires if you try to use it.
zpao
pushed a commit
that referenced
this pull request
Oct 4, 2016
This builds a `react-dom-fiber.js` bundle which exposes ReactDOMFiber. This allows early experiments with the new Fiber reconciler. I also expose it in the npm package through `react-dom/fiber`. (cherry picked from commit f7e0db9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #7164
This builds a
react-dom-fiber.jsbundle which exposes ReactDOMFiber. This allows early experiments with the new Fiber reconciler. I now enable it in the Fiber example.I also expose it in the npm package through
react-dom/fiber.