Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't bundle ReactComponentTreeHook in production #7653

Merged
merged 1 commit into from
Sep 3, 2016
Merged

Don't bundle ReactComponentTreeHook in production #7653

merged 1 commit into from
Sep 3, 2016

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 3, 2016 •
edited

Fixes #7492.
This was a build size regression introduced in #7164.

This should go in 15.4.0 if we ship in #7164 in it so I’ll tag as patch just in case.
Feel free to remove the tag if not necessary.

   raw     gz Compared to master @ 7b247f3609ad25d79ae267b4b5c919a35da45cb4    
     =      = build/react-dom-fiber.js                                         
     =      = build/react-dom-fiber.min.js                                     
     =      = build/react-dom-server.js                                        
     =      = build/react-dom-server.min.js                                    
     =      = build/react-dom.js                                               
     =      = build/react-dom.min.js                                           
  +202    +34 build/react-with-addons.js                                       
 -3967  -1278 build/react-with-addons.min.js                                   
  +192    +44 build/react.js                                                   
 -3979  -1240 build/react.min.js

@gaearon
Don't bundle ReactComponentTreeHook in production
4e1c92e 
Fixes #7492.
This was a build size regression introduced in #7164.
@gaearon gaearon added this to the 15-next milestone Sep 3, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 87.192% when pulling 4e1c92e on gaearon:fix-hook into 7b247f3 on facebook:master.

@vjeux
Copy link
Contributor

vjeux commented Sep 3, 2016

👍

@gaearon gaearon merged commit a09d158 into facebook:master Sep 3, 2016
@gaearon gaearon deleted the fix-hook branch September 3, 2016 21:32
@zpao
Copy link
Member

zpao commented Sep 8, 2016

Going to call this minor since it depends on something else that won't be a patch change.

@gaearon
Copy link
Collaborator Author

gaearon commented Sep 8, 2016

Good luck!

@zpao zpao modified the milestone: 15-next Sep 8, 2016
acdlite pushed a commit to acdlite/react that referenced this pull request Sep 9, 2016
@gaearon @acdlite
Don't bundle ReactComponentTreeHook in production (facebook#7653)
87eb354 
Fixes facebook#7492.
This was a build size regression introduced in facebook#7164.
@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
zpao pushed a commit that referenced this pull request Oct 4, 2016
@gaearon @zpao
Don't bundle ReactComponentTreeHook in production (#7653)
654829d 
Fixes #7492.
This was a build size regression introduced in #7164.
(cherry picked from commit a09d158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zpao zpao

Labels
CLA Signed
Projects
None yet
Milestone
15.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaearon @coveralls @vjeux @zpao