Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn about class components using getInitialState if state is set #8594

Merged
merged 1 commit into from
Dec 17, 2016
Merged

Don't warn about class components using getInitialState if state is set #8594

merged 1 commit into from
Dec 17, 2016

Commits on Dec 17, 2016

  1. Don't warn about class component usage of getInitialState if state is… 

    … also set

We warn about getInitialState() usage in class components because users may have accidentally used it instead of state. If they have also specified state though then we should skip this warning.

Context: https://twitter.com/soprano/status/810003963286163456
    Brian Vaughn committed Dec 17, 2016
    Configuration menu
    Copy the full SHA
    1b868cb View commit details
    Browse the repository at this point in the history