Pass Promise as a parameter to regeneratorRuntime.async() #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
pass-promise
branch
from
1aa1077
to
07c6f32
Compare
This makes it possible to run @babel/plugin-transform-runtime on regenerator's output to provide a Promise polyfill in old browsers.
nicolo-ribaudo
force-pushed
the
pass-promise
branch
from
07c6f32
to
0b6e891
Compare
benjamn
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Thanks for putting this together @nicolo-ribaudo! I honestly wish native async functions could have their Promise implementation reconfigured like this.
|
@nicolo-ribaudo Do you think this should be a minor version bump for |
Co-Authored-By: Ben Newman <ben@benjamn.com>
|
This is fully backwards compatible. It could only break if someone did already pass a fifth parameter to |
|
Thank you! |
This was referenced Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to run
@babel/plugin-transform-runtimeand@babel/preset-env'suseBuiltInsonregenerator's output to provide a Promise polyfill in old browsers.Fixes babel/babel#10678, babel/babel#10830