[RelayCompilerError] Use graphql-js exported utils #2784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2019
Closed
alloy
force-pushed
the
ide-friendly-errors-with-new-graphql-js
branch
from
9787cdd
to
73671f7
Compare
alloy
changed the title
This is the format used by jest, flow, typescript, and many others.
Either an absolute path or a path relative to the wd is necessary for IDEs to find the file in question.
alloy
force-pushed
the
ide-friendly-errors-with-new-graphql-js
branch
from
73671f7
to
ecd1023
Compare
|
Since we're 100% focused on the compiler rewrite and this required some internal changes. I'll close this for now. Better IDE integration is one of our new goals :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graphql-js changes are in master but not yet in a release, so this PR needs to be updated to point to a release once that’s out.Follow-up from #2752 (comment), graphql/graphql-js#1985 (comment), and as discussed in Slack with @josephsavona and @IvanGoncharov.
This change removes graphql-js code that was vendored and uses the newly exported graphql-js utilities instead.