-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate edgeTypeName argument points to an existing type #4621
base: main
Are you sure you want to change the base?
Validate edgeTypeName argument points to an existing type #4621
Conversation
5030ac8
to
77dd653
Compare
So good! Thank you! |
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Still working on landing this. It looks like it's triggering a number of errors internally. Trying to figure out if this is because we're catching real errors (and if so, how we can resolve them), or if there's something else going on here. |
Is this still blocked internally? |
82cd0d7
to
17aa880
Compare
Sorry, haven't been able to revisit. Adding to my todo list for next week. |
So we have many infractions in our codebaese today, and I don't see an obvious way to "fix" these issues at scale. Maybe we need a mechanism to selectively ignore this warning for existing infractions? Perhaps we could leverage our feature flag infra here? Also, would be cool to suggest types with similar names in this error, I think we have examples of that elsewhere in the codebase. |
17aa880
to
1912313
Compare
@captbaritone Added object type suggestions and a feature flag to disable the validation :) |
b70dfa0
to
4fa5509
Compare
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
fb68e19
to
78570c4
Compare
@captbaritone I fixed the conflicts :) |
Currently you can input any string for the
edgeTypeName
argument on the@prependNode
and@appendNode
directives.This change enforces that the value you supply points to an existing object type within the schema.