Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix requestCache conflicts when have multiple ReactRelayQueryRenderer #4632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hannanstd
Copy link

@hannanstd hannanstd commented Feb 28, 2024

Sometimes we have to have two or more ReactRelayQueryRenderer with different environments at the same time.
So the problem is that requestCache is used as a shared variable to hold both environments's caches.
On the other hand, as you know each environment can have its configName while we creating it.
It makes sense that the requestCacheKey consists of this configName to isolate each environment from the others.
This PR does that. see the added Unit Tests.

Also, it can solve some issues that were reported before regarding the SSR.

@facebook-github-bot
Copy link
Contributor

Hi @hannanstd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@captbaritone
Copy link
Contributor

At this point we are not investing in improving the older higher-order-components APIs and are instead focused on the hooks-based APIs.

Do the hooks apis (useLazyLoadQuery, etc) allow you to get the behavior you want?

@hannanstd
Copy link
Author

@captbaritone
Hello, Thank you for your answer. but it is not investing in improving. this problem/bug exists in the relay and many legacy projects use it.
This change would not cause any issues or break changes. it just adds the environment configName to the cachekey and can be reviewed quickly but it helps others.

@hannanstd hannanstd closed this Feb 28, 2024
@hannanstd hannanstd force-pushed the fix_QueryRenderer_requestCache_env_conflict branch from 14d51da to 054e65c Compare February 28, 2024 19:13
@hannanstd hannanstd reopened this Feb 28, 2024
@hannanstd hannanstd force-pushed the fix_QueryRenderer_requestCache_env_conflict branch from ef85cc6 to 8286425 Compare February 28, 2024 19:18
@hannanstd hannanstd force-pushed the fix_QueryRenderer_requestCache_env_conflict branch from 8286425 to 97248ab Compare February 28, 2024 19:24
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants