fix: fix requestCache conflicts when have multiple ReactRelayQueryRenderer #4632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we have to have two or more
ReactRelayQueryRenderer
with different environments at the same time.So the problem is that
requestCache
is used as a shared variable to hold both environments's caches.On the other hand, as you know each environment can have its
configName
while we creating it.It makes sense that the
requestCacheKey
consists of thisconfigName
to isolate each environment from the others.This PR does that. see the added Unit Tests.
Also, it can solve some issues that were reported before regarding the SSR.