Prepare for variable refactorings #4679
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4509
At the moment all diagnostic fixes are simply replacing what's under the cursor with suggestions from the diagnostic data. In order to support more complex refactorings we need to be able to identify the kind of diagnostic we're dealing with when creating a code action.
This adds
codeto the diagnostic as a way to identify a specific diagnostic we want to act upon. Also when resolving a document you now get access to the fullLocationand not just the position span. This is necessary to later map from modifications done to a document (which consists of relative spans) to a full LSP location.