Fix declaration scope of LE_LOAD32 in crc32c #12515
Conversation
Fix build error when __SSE4_2__ is defined:
util/crc32c.cc: In function 'void rocksdb::crc32c::DefaultCRC32(uint64_t*, const uint8_t**)':
util/crc32c.cc:267:53: error: 'LE_LOAD32' was not declared in this scope
267 | *l = _mm_crc32_u32(static_cast<unsigned int>(*l), LE_LOAD32(*p));
| ^~~~~~~~~
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
|
Hi @yizhao1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Could you please take a look at the test failures? Example from https://github.com/facebook/rocksdb/actions/runs/8618647807/job/23621514924?pr=12515: |
Fix build error when SSE4_2 is defined:
util/crc32c.cc: In function 'void rocksdb::crc32c::DefaultCRC32(uint64_t*, const uint8_t**)': util/crc32c.cc:267:53: error: 'LE_LOAD32' was not declared in this scope
267 | *l = _mm_crc32_u32(static_cast(*l), LE_LOAD32(*p));
| ^~~~~~~~~