Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype invoking a post wal write callback in pipelined write mode #12603

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Prototype invoking a post wal write callback in pipelined write mode #12603

wants to merge 2 commits into from

Conversation

jowlyzhang
Copy link
Contributor

@jowlyzhang jowlyzhang commented May 1, 2024 •
edited

This is a prototype PR. Although it's not planned to be checked in, it would be good to have some reviewing feedback before we send it to Hammerspace for integration and testing.

@jowlyzhang jowlyzhang marked this pull request as draft May 1, 2024 23:53
@jowlyzhang jowlyzhang requested review from anand1976 and ajkr May 2, 2024 00:14
anand1976
anand1976 reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@anand1976 anand1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the user specify the callback? In WriteOptions perhaps?

@jowlyzhang
Copy link
Contributor Author

How does the user specify the callback? In WriteOptions perhaps?

Yeah, that's a good question. WriteOptions would work, another idea is maybe we can make WriteWithCallback a public API too?

@anand1976
Copy link
Contributor

How does the user specify the callback? In WriteOptions perhaps?

Yeah, that's a good question. WriteOptions would work, another idea is maybe we can make WriteWithCallback a public API too?

Yeah, WriteWithCallback should be fine too. We should have an overload that doesn't take WriteCallback as that seems specific to transaction DB, and maybe name PostWalWriteCallback to something more generic.

@jowlyzhang jowlyzhang requested a review from anand1976 May 2, 2024 21:59
anand1976
anand1976 reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@anand1976 anand1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR and quick turnaround

@jowlyzhang
Copy link
Contributor Author

LGTM! Thanks for the PR and quick turnaround

Thank you for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anand1976 anand1976 anand1976 left review comments

@ajkr ajkr Awaiting requested review from ajkr

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jowlyzhang @anand1976 @facebook-github-bot