New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
q: How to distinguish Sapling from 馃殏 Steam Locomotive? #597
Comments
related: jestjs/jest#14046, jestjs/jest#14061 |
I don't see anything in the 馃殏 source code which would let us easily detect it. =\ |
Maybe Sapling could distribute two executables: |
worst idea: the whole point of installing 馃殏 is to troll yourself. If you have decided to subject yourself to it, then you deserve what鈥檚 coming for you. The main downside is that in Jest it doesn鈥檛 randomly turn your whole screen into a 馃殏, it just hangs and prints a weird error message. imo if Jest took over your terminal with a 馃殏 animation I would be okay with that, because you installed 馃殏 and it鈥檚 your fault. However, if someone installed 馃殏 two years ago and forgot about it, it鈥檚 going to be really hard for them to figure out why their test runner is broken |
It sounds like Jest's error reporting needs to be improved. |
I can confirm that it was indeed very hard for me to figure out what was going on. I lost hours to this. 馃槄 |
FWIW, I think it's a good idea to distribute a "full" name version. Like |
How so? AFAICT, if we cannot detect if |
Good point. @strager how did you mean "improve Jest's error reporting"? |
@strager's idea to also ship a |
Our attempt is to detect if the first character of the command is attempting to clear the screen when running I'd still like to see a |
I came across this issue as something humorous, so sorry if I'm misunderstanding the requirements, but the Steam Locomotive const TRAIN_CAR_PATTERN = "| |_| |_| |_| |_| |";
const fs = require('fs');
const sl = fs.readFileSync('./sl');
const isSteamLocomotive = sl.includes(TRAIN_CAR_PATTERN); This has the advantage of not requiring you to run |
I know what you're thinking.
I can assure you this Issue is no jest. We are having a problem with some tools that support Sapling where they don't work properly on systems with Steam Locomotive 馃殏 (also called
sl
).My question is: how can we distinguish between systems that have Sapling installed or 馃殏 ?
ideas:
sl --version
shows "Sapling ..."馃殏 --version
just shows the 馃殏checkinconsistent, not portable with Windowsman sl
set a timeout on commands invoking slslow.sl
directory before invokingsl
. Maybe, but this is slowsl
> 1MbI like the last solution best, but would need to resolve symlinks, etc.
馃ぁ
The text was updated successfully, but these errors were encountered: