Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newer fixtures #1194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NickGerleman
Copy link
Contributor

Summary:
flexlayout has the same fixtures forked from Yoga, with some disabled, and some added. This syncs that list to Yoga, adding the fixes made to it along with new fixtures.

One new test absolute_child_with_max_height_larger_shrinkable_grandchild is failing, along with two fixtures where Chrome had recently changed its behaviors. These are commented out at the moment before I do something smarter with the test runner to allow more fixtures.

Differential Revision: D42242096

Summary:
flexlayout has the same fixtures forked from Yoga, with some disabled, and some added. This syncs that list to Yoga, adding the fixes made to it along with new fixtures.

One new test absolute_child_with_max_height_larger_shrinkable_grandchild is failing, along with two fixtures where Chrome had recently changed its behaviors. These are commented out at the moment before I do something smarter with the test runner to allow more fixtures.

Differential Revision: D42242096

fbshipit-source-id: dad07c72101c32b48f7c5a5fa8f46d43d2637222
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42242096

@nicoburns
Copy link
Contributor

@NickGerleman Not the biggest issue, but the test justify_content_colunn_max_height_and_margin has a typo (should be column not colunn) reported to Taffy here DioxusLabs/taffy#330. The issue wasn't introduced by this PR, but maybe it would be a good place to fix it?

@nicoburns
Copy link
Contributor

Looks like gtest allows you to disable tests by prefixing the test name with DISABLED_. Seems like it could be a good way to go for known failures? https://stackoverflow.com/questions/7208070/googletest-how-to-skip-a-test

@NickGerleman
Copy link
Contributor Author

Looks like gtest allows you to disable tests by prefixing the test name with DISABLED_. Seems like it could be a good way to go for known failures? https://stackoverflow.com/questions/7208070/googletest-how-to-skip-a-test

Teaching the test generator to emit annotations to skip tests would be a good concrete step towards getting some of this cleaned up. Patterned after what was done for experimental features, we could maybe add an HTML attribute like skip-test="true" or data-skip-test="true".

Then we would emit for GTest, add test.skip for Jest, etc, for the different test backeends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants