Refactor footer logo default maxWidth + Use Meta Open-Source Logo #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Size Change: +588 B (0%) Total Size: 554 kB
ℹ️ View Unchanged
|
Dist CSS Diffdiff --git a/packages/core/dist/css/default/default.css b/packages/core/dist-branch/css/default/default.css
index 52da5d8..95fc6e3 100644
--- a/packages/core/dist/css/default/default.css
+++ b/packages/core/dist-branch/css/default/default.css
@@ -314,6 +314,7 @@
--ifm-footer-padding-horizontal: calc(var(--ifm-spacing-horizontal) * 2);
--ifm-footer-padding-vertical: calc(var(--ifm-spacing-vertical) * 2);
--ifm-footer-title-color: inherit;
+ --ifm-footer-logo-max-width: min(30rem, 90vw);
--ifm-hero-background-color: var(--ifm-background-surface-color);
--ifm-hero-text-color: var(--ifm-color-emphasis-800);
--ifm-menu-color: var(--ifm-color-emphasis-700);
@@ -2207,7 +2208,7 @@ hr {
.footer__logo {
margin-top: 1rem;
- max-width: 10rem;
+ max-width: var(--ifm-footer-logo-max-width);
}
.footer__title { |
✅ Deploy Preview for infima ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Josh-Cena
reviewed
Jun 23, 2022
.nvmrc
Outdated
| @@ -1 +1 @@ | |||
| 18 | |||
| 16.14.0 | |||
There was a problem hiding this comment.
I prefer to use a lax range. I configured my Bash to automatically switch to the .nvmrc version, and I installed 16.15.0 for v16, so anything declaring a different minor will force me to install another Node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260
By default, the footer logo has a CSS max-width way too small, and it doesn't work great for some logos, requiring CSS override.
Now we use
min(30rem, 90vw):Note:
min()is not supported by a limited set of users (Chinese? cf #260 (comment)): not a big deal in this specific case and support should keep increasing. At worst the footer logo would be too large.Also related to Docusaurus issue facebook/docusaurus#7643, now permitting to provide CSS overrides more conveniently in case 480px is not a good value.
Also reverting to Node 16.14 to fix broken Netlify deployment after #261)