Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove step to save ccache from scheduled jobs #9433

Closed

Conversation

bikramSingh91
Copy link
Contributor

Saving ccache is resulting in some errors finalizing the upload
which is preventing scheduled jobs from running. Removing this
step temporarily till its resolved.

Saving ccache is resulting in some errors finalizing the upload
which is preventing scheduled jobs from running. Removing this
step temporarily till its resolved.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit db2b481
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6616ead2e80e8a0008a226d0

@facebook-github-bot
Copy link
Contributor

@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bikramSingh91 merged this pull request in a9897b1.

Copy link

Conbench analyzed the 1 benchmark run on commit a9897b11.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@assignUser
Copy link
Collaborator

assignUser commented Apr 11, 2024

This is caused by an underlying, flakey issue of the artifacts back end, there is nothing we can do see actions/upload-artifact#543

Removing the step is a bit heavy handed we can just add continue-on-error to avoid the job failing if the action fails. I have added that change to #9420

@assignUser
Copy link
Collaborator

assignUser commented Apr 11, 2024

Actually it seems the latest release updated the npm package used to work with the backend, I'll drop the version used in the action down to 4.3.0 for now. edit: done, the fix is in the v1 tag so will apply automatically here

yanngyoung pushed a commit to yanngyoung/velox that referenced this pull request Apr 12, 2024
…ncubator#9433)

Summary:
Saving ccache is resulting in some errors finalizing the upload
which is preventing scheduled jobs from running. Removing this
step temporarily till its resolved.

Pull Request resolved: facebookincubator#9433

Reviewed By: kgpai

Differential Revision: D55987674

Pulled By: bikramSingh91

fbshipit-source-id: bc5655df1ef96dbd710871b0f1ed30b06cf41e4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants