Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the great package, I'm relying on it quite a bit now, I'm just encountering two issues:
d.nextBit >= len(newClient.drillBits)
buteindex
can remain out of range.go-drill/client.go
Line 155 in eb99719
mydrillbit
instead of/drill/mydrillbit
.go-drill/zk_handler.go
Line 76 in eb99719
This causes the connection to error ("invalid path") but it seems
z.Err
is never really checked. I'm not sure where this should be checked though.go-drill/zk_handler.go
Line 78 in eb99719
This PR fixes these, though maybe not elegantly.