-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: update GitHub action #3580
base: master
Are you sure you want to change the base?
Conversation
There is no need to waste processing time on Python 3.6 which is no longer supported. |
There is no reason to remove it, is there one? Also you removed pypy which we still official support, why? |
Python 3.6 reached upstream end-of-life on December 23rd, 2021, and no longer receives security or bug fixes. Apps still using it contain potential security vulnerabilities. Boxes which still depend on Python 3.6 typically will contain more old software with severe security issues. But they still can use all tagged versions of fail2ban (although I doubt that will help much). For Git master there is simply no reason why Python 3.6 should be supported. Removing it saves resources and is a necessary step to allow an update of the CI runner to a recent Ubuntu version which no longer provides Python 3.6. The current PyPI configuration "pypy3" tests Python 3.6, too, so there are currently two CI jobs with Python 3.6, and I suggest to drop both for Git master (not for the branches!). The action setup-python@v4 no longer supports "pypy3". If a replacement is desired for Git master, I suggest to add a more specific "pypi3.10" (or any other release). |
And the reason to switch to recent Ubuntu version is? (I know at some point it'd be necessary but...)
Agree. Can you do that in this PR? |
.github/workflows/main.yml
Outdated
@@ -22,15 +22,15 @@ jobs: | |||
runs-on: ubuntu-20.04 | |||
strategy: | |||
matrix: | |||
python-version: [3.6, 3.7, 3.8, 3.9, '3.10', '3.11', pypy3] | |||
python-version: [3.7, 3.8, 3.9, '3.10', '3.11'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some pypy version would be nice
There are several cached releases in the Ubuntu runner. I suggest to select one or two of those. Which ones would you prefer? More pypy releases are supported, but they might require more processing time because they are not cached.. |
8353a4c
to
b1ba4c1
Compare
I now updated the PR with a new job for pypy3.10. |
- remove two jobs for Python 3.6 (no longer supported) - update versions for used actions - remove whitespace at line ending - add job for pypy3.10 Signed-off-by: Stefan Weil <sw@weilnetz.de>
b1ba4c1
to
1e04837
Compare
Before submitting your PR, please review the following checklist:
against certain release version, choose
0.9
,0.10
or0.11
branch,for dev-edition use
master
branchfailregex
for filterX
with sample log lineswithin
fail2ban/tests/files/logs/X
file