Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create dockerfile #1

Merged
merged 15 commits into from
May 12, 2020
Merged

Feature/create dockerfile #1

merged 15 commits into from
May 12, 2020

Conversation

dsmits
Copy link
Collaborator

@dsmits dsmits commented May 12, 2020

No description provided.

@dsmits dsmits requested a review from raar1 May 12, 2020 12:16
@dsmits dsmits force-pushed the feature/create-dockerfile branch from ecd9a65 to bca75fb Compare May 12, 2020 13:43
@dsmits
Copy link
Collaborator Author

dsmits commented May 12, 2020

WARNING! Please review PR #2 first!

Copy link
Contributor

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested building the docker image on my mac laptop and it worked nicely. Extension loads in browser and has correct behaviour.

@raar1 raar1 merged commit 88514ea into master May 12, 2020
@raar1 raar1 deleted the feature/create-dockerfile branch May 12, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants