Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Split out API reference docs #1174

Closed
alliesaizan opened this issue Jan 12, 2023 · 7 comments
Closed

DOC Split out API reference docs #1174

alliesaizan opened this issue Jan 12, 2023 · 7 comments

Comments

@alliesaizan
Copy link
Contributor

Describe the issue linked to the documentation

Currently, the API docs for each module include all the components of that module on one page, as shown below:

image

Suggest a potential alternative/fix

Suggest splitting the docs up so that each component in the module gets its own page, like in the image below:

image

This issue was brought up during the weekly community call on 1/12/23, and I found a package that can automatically split up Sphinx docs, sphinx-audomodapi.

Looping in @hildeweerts @MiroDudik @romanlutz to see if this package would work for this use case (also @hildeweerts, let me know if I misinterpreted the issue you mentioned!). I'd be happy to research this more and submit a PR if you think this would be a good solution!

@alliesaizan alliesaizan changed the title Split out API reference docs DOC Split out API reference docs Jan 12, 2023
@romanlutz
Copy link
Member

romanlutz commented Jan 12, 2023

I checked what scikit-learn does for this since they have exactly what we want in a working state. I think I got something promising with just "autosummary". I pushed it to a little branch. Feel free to build on that if you want! https://github.com/fairlearn/fairlearn/tree/romanlutz/separate_page_per_class_and_func
[Sorry for pushing the branch to the main repo, that was a mistake, but I guess it'll work....]

@alliesaizan
Copy link
Contributor Author

Oh np, autosummary was another way I saw to do this! If that's working then I will close this issue :)

@romanlutz
Copy link
Member

TBH I don't know about pros and cons of each option. autosummary just looks pretty straightforward and staying in somewhat close alignment with scikit-learn is typically a good idea as we can keep adopting their innovations 🙂 Let's leave the issue open until a PR is out and merged (?)
I'll leave it up to you whether you want to try this or not. If not, I might be able to try it over the next few weeks, but no guarantee.

@hildeweerts
Copy link
Contributor

This is exactly the issue I was referring to @alliesaizan!

About a million years ago I opened an issue for this #720, I will close that one in favor of this new issue.

@alliesaizan
Copy link
Contributor Author

TBH I don't know about pros and cons of each option. autosummary just looks pretty straightforward and staying in somewhat close alignment with scikit-learn is typically a good idea as we can keep adopting their innovations 🙂 Let's leave the issue open until a PR is out and merged (?) I'll leave it up to you whether you want to try this or not. If not, I might be able to try it over the next few weeks, but no guarantee.

Gotcha, I will apply the autosummary method to all the modules and send a PR!

@romanlutz
Copy link
Member

This looks like it's completed. @hildeweerts can you close if you agree? This technically goes all the way back to #455 so I want to make sure it's addressed in a way that's consistent with your expectations 🙂

@hildeweerts
Copy link
Contributor

Similar to @adrinjalali I'm not a huge fan of listing everything on the left hand side, but we can look into that in the future if it's really bothering people. Will close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants