Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add abbreviations to hacker.abbreviation() in the en locale #1086

Merged
merged 9 commits into from
Jun 18, 2022
Merged

feat: add abbreviations to hacker.abbreviation() in the en locale #1086

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b47a541
feat: add abbreviations to hacker.abbreviation()
import-brain Jun 17, 2022
d9dd86a
Merge branch 'main' into hacker_abbreviation
import-brain Jun 17, 2022
582283e
chore: apply suggestions from code review
import-brain Jun 18, 2022
c653b01
Merge branch 'main' into hacker_abbreviation
import-brain Jun 18, 2022
a945acc
chore: sort abbreviations alphabetically
import-brain Jun 18, 2022
2dc17f9
Update src/locales/en/hacker/abbreviation.ts
import-brain Jun 18, 2022
7fa7f4f
fix: abbreviation tests
import-brain Jun 18, 2022
fd1ac63
Merge branch 'main' into hacker_abbreviation
import-brain Jun 18, 2022
7d1fa12
test: removed seededRuns object in hacker test
Shinigami92 Jun 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
54 changes: 33 additions & 21 deletions src/locales/en/hacker/abbreviation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,43 @@
export default [
'TCP',
'HTTP',
'SDD',
'RAM',
'GB',
'CSS',
'SSL',
'ADP',
'AGP',
'SQL',
'FTP',
'PCI',
'AI',
'ADP',
'RSS',
'XML',
'EXE',
'API',
'ASCII',
import-brain marked this conversation as resolved.
Show resolved Hide resolved
'CLI',
'COM',
'CSS',
'DNS',
'DRAM',
'EXE',
'FTP',
'GB',
'HDD',
'THX',
'SMTP',
'SMS',
'USB',
'HEX',
'HTTP',
'IB',
'IP',
'JBOD',
'JSON',
'OCR',
'PCI',
'PNG',
'RAM',
'RSS',
'SAS',
'IB',
'SCSI',
'JSON',
'SDD',
'SMS',
'SMTP',
'SQL',
'SSL',
import-brain marked this conversation as resolved.
Show resolved Hide resolved
'TCP',
'THX',
'TLS',
'UDP',
'USB',
'UTF8',
'VGA',
'XML',
'XSS',
'JBOD',
];
12 changes: 6 additions & 6 deletions test/hacker.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const seededRuns = [
seed: 42,
expectations: {
abbreviation: {
noArgs: 'PCI',
noArgs: 'HTTP',
},
adjective: {
noArgs: 'cross-platform',
Expand All @@ -22,15 +22,15 @@ const seededRuns = [
},
phrase: {
noArgs:
'Try to transmit the SAS microchip, maybe it will quantify the mobile monitor!',
'Try to transmit the TCP microchip, maybe it will quantify the mobile monitor!',
},
},
},
{
seed: 1337,
expectations: {
abbreviation: {
noArgs: 'AGP',
noArgs: 'EXE',
},
adjective: {
noArgs: 'open-source',
Expand All @@ -46,15 +46,15 @@ const seededRuns = [
},
phrase: {
noArgs:
'Try to generate the COM program, maybe it will connect the back-end port!',
'Try to generate the PNG program, maybe it will connect the back-end port!',
},
},
},
{
seed: 1211,
expectations: {
abbreviation: {
noArgs: 'JSON',
noArgs: 'VGA',
},
adjective: {
noArgs: 'solid state',
Expand All @@ -70,7 +70,7 @@ const seededRuns = [
},
phrase: {
noArgs:
"I'll back up the neural RSS program, that should panel the SCSI matrix!",
"I'll back up the neural JBOD program, that should panel the USB matrix!",
},
},
},
Expand Down