Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom randomizer #2284

Merged
merged 33 commits into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
97a7163
feat: custom prng
ST-DDT Jul 31, 2023
b575dc6
Merge branch 'next' into feat/custom-prng
ST-DDT Aug 6, 2023
8a67fc8
chore: rename generateMersennePRNG
ST-DDT Aug 6, 2023
ae647a0
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 15, 2023
1c82b96
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 19, 2023
f3d0165
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 19, 2023
4c3b809
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 19, 2023
646ef43
chore: cleanup
ST-DDT Sep 19, 2023
d2e576d
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 19, 2023
d369826
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 21, 2023
4ca657c
docs: enhance docs
ST-DDT Sep 21, 2023
d40e9e3
chore: rename
ST-DDT Sep 21, 2023
041160c
chore: fix typo
ST-DDT Sep 21, 2023
dad23bc
chore: fix typo
ST-DDT Sep 21, 2023
41e80d4
chore: improve example
ST-DDT Sep 21, 2023
745ffb3
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 22, 2023
34729c8
chore: fix typo
ST-DDT Sep 22, 2023
eea7318
docs: improve jsdoc usage hints
ST-DDT Sep 22, 2023
4487925
chore: move Randomizer to the end
ST-DDT Sep 22, 2023
c6cbcea
chore: simplify
ST-DDT Sep 22, 2023
2374c90
chore: use pure-rand example
ST-DDT Sep 22, 2023
db446d3
docs: create SimpleFaker in example
ST-DDT Sep 22, 2023
e40856d
docs: create SimpleFaker in example
ST-DDT Sep 22, 2023
e3dd059
chore: don't use mersenne
ST-DDT Sep 22, 2023
a072b6e
Update src/randomizer.ts
ST-DDT Sep 22, 2023
42ac780
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 23, 2023
dc78ddf
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 24, 2023
cb3691f
docs: simplify
ST-DDT Sep 24, 2023
7a39e1a
Merge branch 'next' into feat/custom-prng
ST-DDT Sep 29, 2023
6bf7d56
docs: improve documentation
ST-DDT Oct 2, 2023
3574711
Merge branch 'next' into feat/custom-prng
ST-DDT Oct 2, 2023
67bada3
docs: slightly adjust examples
ST-DDT Oct 2, 2023
f98c2ee
chore: add nav entry
ST-DDT Oct 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 27 additions & 5 deletions src/faker.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import type { LocaleDefinition, MetadataDefinition } from './definitions';
import { FakerError } from './errors/faker-error';
import { deprecated } from './internal/deprecated';
import type { Mersenne } from './internal/mersenne/mersenne';
import mersenne from './internal/mersenne/mersenne';
import { generateMersennePRNG } from './internal/mersenne';
import type { LocaleProxy } from './locale-proxy';
import { createLocaleProxy } from './locale-proxy';
import { AirlineModule } from './modules/airline';
Expand Down Expand Up @@ -33,6 +32,7 @@ import { StringModule } from './modules/string';
import { SystemModule } from './modules/system';
import { VehicleModule } from './modules/vehicle';
import { WordModule } from './modules/word';
import type { PRNG } from './prng';
import { mergeLocales } from './utils/merge-locales';

/**
Expand Down Expand Up @@ -114,7 +114,7 @@ export class Faker {
}

/** @internal */
private readonly _mersenne: Mersenne = mersenne();
private readonly _prng: PRNG;

/**
* @deprecated Use the modules specific to the type of data you want to generate instead.
Expand Down Expand Up @@ -184,6 +184,8 @@ export class Faker {
*
* @param options The options to use.
* @param options.locale The locale data to use.
* @param options.prng The PRNG to use. Defaults to faker's Mersenne Twister based PRNG.
* Only overwrite this if you want to reuse the same PRNG in different libraries to ensure reproducible results across all of them.
*
* @example
* import { Faker, es } from '@faker-js/faker';
Expand All @@ -205,6 +207,14 @@ export class Faker {
* @see mergeLocales
*/
locale: LocaleDefinition | LocaleDefinition[];

/**
* The PRNG to use. Defaults to faker's Mersenne Twister based PRNG.
* Only overwrite this if you want to reuse the same PRNG in different libraries to ensure reproducible results across all of them.
*
* @default newMersennePRNG()
*/
prng?: PRNG;
ST-DDT marked this conversation as resolved.
Show resolved Hide resolved
});
/**
* Creates a new instance of Faker.
Expand Down Expand Up @@ -241,6 +251,8 @@ export class Faker {
* @param options.locale The locale data to use or the name of the main locale.
* @param options.locales The locale data to use.
* @param options.localeFallback The name of the fallback locale to use.
* @param options.prng The PRNG to use. Defaults to faker's Mersenne Twister based PRNG.
* Only overwrite this if you want to reuse the same PRNG in different libraries to ensure reproducible results across all of them.
*
* @example
* import { Faker, es } from '@faker-js/faker';
Expand All @@ -264,6 +276,14 @@ export class Faker {
* @see mergeLocales
*/
locale: LocaleDefinition | LocaleDefinition[];

/**
* The PRNG to use. Defaults to faker's Mersenne Twister based PRNG.
* Only overwrite this if you want to reuse the same PRNG in different libraries to ensure reproducible results across all of them.
*
* @default newMersennePRNG()
*/
prng?: PRNG;
}
| {
/**
Expand Down Expand Up @@ -292,11 +312,12 @@ export class Faker {
);
constructor(
options:
| { locale: LocaleDefinition | LocaleDefinition[] }
| { locale: LocaleDefinition | LocaleDefinition[]; prng?: PRNG }
| {
locales: Record<string, LocaleDefinition>;
locale?: string;
localeFallback?: string;
prng?: PRNG;
}
) {
const { locales } = options as {
Expand Down Expand Up @@ -332,6 +353,7 @@ export class Faker {
locale = mergeLocales(locale);
}

this._prng = options.prng ?? generateMersennePRNG();
this.rawDefinitions = locale as LocaleDefinition;
this.definitions = createLocaleProxy(this.rawDefinitions);
}
Expand Down Expand Up @@ -453,7 +475,7 @@ export class Faker {
seed(
seed: number | number[] = Math.ceil(Math.random() * Number.MAX_SAFE_INTEGER)
): number | number[] {
this._mersenne.seed(seed);
this._prng.seed(seed);

return seed;
}
Expand Down
28 changes: 27 additions & 1 deletion src/internal/mersenne/twister.ts → src/internal/mersenne.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import type { PRNG } from '../prng';

/**
* Copyright (c) 2022-2023 Faker
*
Expand Down Expand Up @@ -71,7 +73,7 @@
*
* @internal
*/
export default class MersenneTwister19937 {
class MersenneTwister19937 {
private readonly N = 624;
private readonly M = 397;
private readonly MATRIX_A = 0x9908b0df; // constant vector a
Expand Down Expand Up @@ -323,3 +325,27 @@ export default class MersenneTwister19937 {
}
// These real versions are due to Isaku Wada, 2002/01/09
}

/**
* Generate seed based random numbers.
*
* @internal
*/
export function generateMersennePRNG(): PRNG {
const twister = new MersenneTwister19937();

twister.initGenrand(Math.ceil(Math.random() * Number.MAX_SAFE_INTEGER));

return {
next(): number {
return twister.genrandReal2();
},
seed(seed: number | number[]): void {
if (typeof seed === 'number') {
twister.initGenrand(seed);
} else if (Array.isArray(seed)) {
twister.initByArray(seed, seed.length);
}
},
};
}
45 changes: 0 additions & 45 deletions src/internal/mersenne/mersenne.ts

This file was deleted.

13 changes: 6 additions & 7 deletions src/modules/number/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Faker } from '../..';
import { FakerError } from '../../errors/faker-error';
import { bindThisToMemberFunctions } from '../../internal/bind-this-to-member-functions';
import type { Mersenne } from '../../internal/mersenne/mersenne';
import type { PRNG } from '../../prng';

/**
* Module to generate numbers of any kind.
Expand Down Expand Up @@ -83,10 +83,9 @@ export class NumberModule {
throw new FakerError(`Max ${max} should be greater than min ${min}.`);
}

const mersenne: Mersenne =
// @ts-expect-error: access private member field
this.faker._mersenne;
const real = mersenne.next();
// @ts-expect-error: access private member field
const { _prng: prng }: PRNG = this.faker;
const real = prng.next();
return Math.floor(real * (effectiveMax + 1 - effectiveMin) + effectiveMin);
}

Expand Down Expand Up @@ -160,8 +159,8 @@ export class NumberModule {
}

// @ts-expect-error: access private member field
const mersenne: Mersenne = this.faker._mersenne;
const real = mersenne.next();
const { _prng: prng }: PRNG = this.faker;
const real = prng.next();
return real * (max - min) + min;
}

Expand Down
17 changes: 17 additions & 0 deletions src/prng.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/**
* Interface for a pseudo-random number generator.
*/
export interface PRNG {
/**
* Generates a random float between `[0, 1)`.
* This method is called `next` so that it could be used as an [iterator](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Iteration_protocols#the_iterator_protocol)
*/
next(): number;

/**
* Sets the seed to use.
*
* @param seed The seed to use.
*/
seed(seed: number | number[]): void;
}

Check warning on line 17 in src/prng.ts

View check run for this annotation

Codecov / codecov/patch

src/prng.ts#L2-L17

Added lines #L2 - L17 were not covered by tests
2 changes: 1 addition & 1 deletion test/all_functional.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const IGNORED_MODULES = [
'rawDefinitions',
'definitions',
'helpers',
'_mersenne',
'_prng',
'_defaultRefDate',
];

Expand Down
16 changes: 16 additions & 0 deletions test/faker.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,22 @@ describe('faker', () => {
});
});

describe('prng', () => {
it('should be possible to provide a custom prng', () => {
const customFaker = new Faker({
locale: {},
prng: {
next: () => 0,
seed: () => void 0,
},
});

expect(customFaker.number.int()).toBe(0);
expect(customFaker.number.int()).toBe(0);
expect(customFaker.number.int()).toBe(0);
});
});

// This is only here for coverage
// The actual test is in mersenne.spec.ts
describe('seed()', () => {
Expand Down
14 changes: 7 additions & 7 deletions test/mersenne.spec.ts
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
import { beforeAll, beforeEach, describe, expect, it } from 'vitest';
import type { Mersenne } from '../src/internal/mersenne/mersenne';
import mersenneFn from '../src/internal/mersenne/mersenne';
import { generateMersennePRNG } from '../src/internal/mersenne';
import type { PRNG } from '../src/prng';
import { seededRuns } from './support/seededRuns';
import { times } from './support/times';

const NON_SEEDED_BASED_RUN = 25;

describe('mersenne twister', () => {
const mersenne: Mersenne = mersenneFn();
const prng: PRNG = generateMersennePRNG();

describe.each(
[...seededRuns, ...seededRuns.map((v) => [v, 1, 2])].map((v) => [v])
)('seed: %j', (seed) => {
beforeEach(() => {
mersenne.seed(seed);
prng.seed(seed);
});

it('should return deterministic value for next()', () => {
const actual = mersenne.next();
const actual = prng.next();

expect(actual).toMatchSnapshot();
});
Expand All @@ -35,12 +35,12 @@ describe('mersenne twister', () => {
])
)('random seeded tests %j', (seed) => {
beforeAll(() => {
mersenne.seed(seed);
prng.seed(seed);
});

describe('next', () => {
it('should return random number from interval [0, 1)', () => {
const actual = mersenne.next();
const actual = prng.next();

expect(actual).toBeGreaterThanOrEqual(0);
expect(actual).toBeLessThan(1);
Expand Down