Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v9 #2798

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 8, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) 8.57.0 -> 9.0.0 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner April 8, 2024 00:36
@renovate renovate bot added c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent labels Apr 8, 2024
@renovate renovate bot added this to the vAnytime milestone Apr 8, 2024
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 130504e
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/662032af8a5d460008f7cd49
😎 Deploy Preview https://deploy-preview-2798.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (100abac) to head (130504e).
Report is 30 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2798      +/-   ##
==========================================
- Coverage   99.95%   99.94%   -0.01%     
==========================================
  Files        2964     2964              
  Lines      212544   212544              
  Branches      600      942     +342     
==========================================
- Hits       212451   212432      -19     
- Misses         93      112      +19     

see 2 files with indirect coverage changes

@renovate renovate bot force-pushed the renovate/major-eslint branch 2 times, most recently from c663f98 to 56ad741 Compare April 8, 2024 07:18
@Shinigami92 Shinigami92 self-assigned this Apr 8, 2024
@Shinigami92
Copy link
Member

I would like to explore the new eslint v9 and migrate to FlatConfig, so if nobody else has something against that, I would like to "claim" this PR and address some of my time in the upcoming days for this

@renovate renovate bot force-pushed the renovate/major-eslint branch 5 times, most recently from 92c3bfb to db4f46f Compare April 8, 2024 10:43
@renovate renovate bot changed the title chore(deps): update eslint (major) chore(deps): update dependency eslint to v9 Apr 8, 2024
@Shinigami92 Shinigami92 marked this pull request as draft April 8, 2024 15:05
Copy link
Contributor Author

renovate bot commented Apr 8, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@Shinigami92 Shinigami92 force-pushed the renovate/major-eslint branch 2 times, most recently from e0ed0a4 to 3605045 Compare April 8, 2024 15:29
Comment on lines +14 to +21
// Skip self linting
'eslint.config.js',
// Skip some files that don't need linting right now
'.github/workflows/commentCodeGeneration.ts',
'.prettierrc.js',
'docs/.vitepress/components/shims.d.ts',
'docs/.vitepress/shared/utils/slugify.ts',
'docs/.vitepress/theme/index.ts',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are getting not applied somehow right now 🤔

Comment on lines +122 to +125
// TODO @Shinigami92 2024-04-08: Add eslint-plugin-deprecation later
// https://github.com/gund/eslint-plugin-deprecation/issues/78
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint.config.js Show resolved Hide resolved
@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label Apr 8, 2024
@ST-DDT ST-DDT mentioned this pull request Apr 15, 2024
1 task
@Shinigami92 Shinigami92 removed the s: on hold Blocked by something or frozen to avoid conflicts label Apr 17, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Apr 17, 2024

I can confirm that pnpm eslint . freezes if pnpm run build was run/when dist exists. Same for docs/.vitepress/cache not sure how that gets created.

@Shinigami92
Copy link
Member

Meanwhile in another project I tested out eslint v9 using ESLINT_USE_FLAT_CONFIG=false and it destroys VSCode's eslint extension, so no auto-fix suggestions are made in VSCode anymore at all.
So using this strategy to at least bump up the dependency is non-viable 😕

@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants