feat: add option to exclude emoji #2851
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2851 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2973 2973
Lines 212501 212536 +35
Branches 950 951 +1
==========================================
+ Hits 212429 212462 +33
- Misses 72 74 +2
|
ST-DDT
added
c: feature
| * | ||
| * @default Object.keys(faker.definitions.person.bio_pattern) | ||
| */ | ||
| types?: ReadonlyArray<BioType>; |
There was a problem hiding this comment.
Method options usally not provide extra or even replacement locale data. We usually allow users to control the method outcome through flags. In this case I could see such an option being named "includeEmojis" or "allowEmojis". We have similar options for:
| this.faker.definitions.person.bio_pattern | ||
| ) as BioType[], | ||
| } = options; | ||
| const bioType = this.faker.helpers.arrayElement(types); |
There was a problem hiding this comment.
Couldn't we simply get rid of '{{internet.emoji}}' here?
There was a problem hiding this comment.
Maybe lets check the requirements and intentions behind including emojis in the next team meeting.
#2623 (comment)