Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(vitest): prefer-to-have-length #2900

Merged
merged 2 commits into from May 14, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 13, 2024

Enables the vitest/prefer-to-have-length lint rule.

  • expect(value).toHaveLength: 89
  • expect(value.length).toBe: 7

Except very slow reaction times from my side this week.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test c: infra Changes to our infrastructure or project setup labels May 13, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 13, 2024
@ST-DDT ST-DDT requested review from a team May 13, 2024 11:46
@ST-DDT ST-DDT self-assigned this May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit e8f1517
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66438e7d106ac700084e536e
😎 Deploy Preview https://deploy-preview-2900.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (044a756) to head (e8f1517).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2900      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2977     2977              
  Lines      215466   215466              
  Branches      599      951     +352     
==========================================
- Hits       215395   215387       -8     
- Misses         71       79       +8     

see 2 files with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) May 14, 2024 16:17
@ST-DDT ST-DDT merged commit 7fb9bb5 into next May 14, 2024
20 checks passed
@ST-DDT ST-DDT deleted the infra/vitest/prefer-to-have-length branch May 14, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup c: test p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants