Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve luhn checks (error messages only) #981

Merged
merged 4 commits into from May 22, 2022
Merged

test: improve luhn checks (error messages only) #981

merged 4 commits into from May 22, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 21, 2022 •
edited

Basically:

- expect(luhnCheck(visa)).toBeTruthy();
+ expect(visa).toSatisfy(luhnCheck);

Blocked by vitest-dev/vitest#1350

⚠️ None of our toSatisfy tests are working ⚠️

@ST-DDT ST-DDT added s: on hold Blocked by something or frozen to avoid conflicts p: 1-normal Nothing urgent c: test labels May 21, 2022
@ST-DDT ST-DDT requested review from a team May 21, 2022 16:35
@ST-DDT ST-DDT self-assigned this May 21, 2022
@codecov
Copy link

codecov bot commented May 21, 2022 •
edited

Codecov Report

Merging #981 (177f902) into main (b87dec8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files        1988     1988           
  Lines      211108   211108           
  Branches      908      908           
=======================================
  Hits       210381   210381           
  Misses        708      708           
  Partials       19       19

@ST-DDT ST-DDT mentioned this pull request May 21, 2022
Merged
@ST-DDT
Copy link
Member Author

ST-DDT commented May 21, 2022

Upstream fix merged and released.
Now blocked by: #982

@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label May 21, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented May 21, 2022

Update has been merged and seems to be working fine.

@Shinigami92 Shinigami92 enabled auto-merge (squash) May 22, 2022 11:08
@Shinigami92 Shinigami92 merged commit bd4d3db into main May 22, 2022
@Shinigami92 Shinigami92 deleted the test/luhn/failure-messages branch May 22, 2022 11:13
@xDivisionByZerox xDivisionByZerox added m: finance Something is referring to the finance module m: helpers Something is referring to the helpers module labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuczynski pkuczynski pkuczynski approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: test m: finance Something is referring to the finance module m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7.0 - Structural Breaking Changes
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ST-DDT @pkuczynski @Shinigami92 @import-brain @xDivisionByZerox