Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Add support for .yaml files in fal dbt parser #685

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

nabilm
Copy link
Contributor

@nabilm nabilm commented Dec 12, 2022

Description

Since in dbt project people can use a variety of .yaml, and .yml files, I added the support for scanning .yaml files

GitHub: resolves #684

@chamini2 chamini2 self-requested a review December 12, 2022 22:57
@chamini2
Copy link
Member

Hello, @nabilm. Thanks for this!

Could you pleas rebase from main? I just merged https://github.com/fal-ai/fal/pull/686 which fixes test setup for GitHub so we can see if this changes anything unexpectedly.

Also, could you change some of the integration tests to have yaml instead of yml files? So we can see it behaves the same.

Let me know if you have any questions through here, Discord or dbt Slack.

Copy link
Member

@chamini2 chamini2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @nabilm!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fal read only dbt *.yml files and ignore *.yaml
2 participants